-
-
Notifications
You must be signed in to change notification settings - Fork 475
[17.0][MIG] account_payment_term_partner_paydays #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] account_payment_term_partner_paydays #908
Conversation
… new method Extract the paument days applicaton logic to a new method so that the logic can be easily inherited or modified
|
ping @MarinaAForgeFlow |
rrebollo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
a955b4e to
825189c
Compare
MarinaAForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. LGTM
|
This PR has the |
adasatorres
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM!!
@BinhexTeam
Based on
#839
Depends on
#907